search

amethyst / editor-core

Crate that allows an Amethyst game to communicate with an editor.
Other
44 stars 10 forks source link

Panic on Linux when no editor running #15

Closed randomPoison closed 6 years ago

randomPoison commented 6 years ago

Original bug report from @jojolepro:

Using amethyst-editor-sync in a game when the editor is closed leads to a crash. thread '' panicked at 'Failed to send message: Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }

I should note that I don't see this issue on Windows, and it's a very weird issue considering we're using UDP, which doesn't actually have a concept of connections 🤔 This might be because we're using UdpSocket::connect.

Note that while this might be easy to solve for UDP, we also want to switch to TCP in order to fix #12, so we'd end up running into the same issue with TCP anyway.

randomPoison commented 6 years ago

Note that this issue is causing problems for running automated tests under Travis-CI because the tests are run under Linux and there's no editor to connect to.

randomPoison commented 6 years ago

@jojolepro could you try patching in the latest commit on master (3b2d82d) and see if you still see this issue happening? If so, I can re-open this issue, but otherwise it seems fixed when running on Travis-CI.

AnneKitsune commented 6 years ago

Can't reproduce on master