search

amethyst / editor-core

Crate that allows an Amethyst game to communicate with an editor.
Other
44 stars 10 forks source link

Readonly components require Deserialize #38

Closed jjedelsky closed 5 years ago

jjedelsky commented 6 years ago

https://github.com/randomPoison/amethyst-editor-sync/blob/6c0871e2e65e9cfbb5d54b395215c8871786363a/src/lib.rs#L327

Is there any reason why read_components needs WriteComponentSet and therefore Deserialize?

randomPoison commented 6 years ago

Nope! It's totally a mistake on my part 😓 Feel free to open a pull request fixing it if you'd like, otherwise I'll get this fixed in the next release 🙂

randomPoison commented 5 years ago

This was fixed in #40, it'll be released in version 0.4.