amethyst / rustrogueliketutorial

Roguelike Tutorial in Rust - using RLTK
MIT License
905 stars 156 forks source link

Town buildings are populated in wrong order #148

Open smokku opened 4 years ago

smokku commented 4 years ago

My Player got spawned in a building so small, that it didn't even fit Barkeep, so I started investigating.

Code in _town.rs/buildingfactory is incorrect. It iterates over original buildings array, and uses its index to pick build_type form building_index array, which was sorted and has different indexing:

for (i, building) in buildings.iter().enumerate() {
    let build_type = &building_index[i].2;
    match build_type {

It should be changed to something like this:

for (i, _size, build_type) in building_index.iter() {
    let building = &buildings[*i];
    match build_type {
MasterDrake commented 6 months ago

Much better, makes sense! Thank you!