search

amethyst / sheep

Modular and lightweight spritesheet packer 🐑
Other
89 stars 12 forks source link

Add trimming support #14

Closed basil-cow closed 5 years ago

basil-cow commented 5 years ago

First time contibuting to open source so I'm not sure I'm doing everything right

happenslol commented 5 years ago

Awesome, looks good to me! Could you add 1 or 2 tests for this? Just to make sure we don't regress if we change anything about how sprite data and stride is handled.

happenslol commented 5 years ago

Awesome, thanks a lot! The only thing I can think of that we could still add would be a way for the user to define which colors he wants to be treated as "transparent". Some people use a color key for 2D instead of an image format capable of transparency.

I'd totally be okay with merging this as is though, and adding that feature at a later point.

If you resolve the merge conflicts, I'll get it merged =)