search

amethyst / shred

Shared resource dispatcher
Apache License 2.0
234 stars 66 forks source link

Remove `::` prefix from derived implementation. #103

Closed azriel91 closed 5 years ago

azriel91 commented 5 years ago

This allows an in-scope re-exported shred crate to be used.

Closes #102

I'll test this in a larger project, give me a few days to get to it.

azriel91 commented 5 years ago

Hm, the changes were more of a "get the user to explicitly use shred" instead of a Rust 2018 change. Would you still like it to be behind a feature gate? (can't find a way to detect based on edition)

torkleyy commented 5 years ago

Hmm, that would make it a breaking change...

On Tue, Dec 11, 2018, 08:23 Azriel Hoh <notifications@github.com wrote:

Hm, the changes were more of a "get the user to explicitly use shred" instead of a Rust 2018 change. Would you still like it to be behind a feature gate? (can't find a way to detect based on edition)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/slide-rs/shred/pull/103#issuecomment-446098563, or mute the thread https://github.com/notifications/unsubscribe-auth/AWFFufu1XhnKUbfjY4m-AE5ACwWlB5JMks5u311kgaJpZM4ZFpBM .

azriel91 commented 5 years ago

that would make it a breaking change

yeap, would mean shred-derive 0.6; shred itself doesn't change so can stay at 0.7.1

whether shred or the individual symbols should be used

Going by the other crates, I'd go with the individual symbols for consistency. Reminder for myself: even if shred was re-exported under a different name, you can still import it as shred.

azriel91 commented 5 years ago

Pushed a change for the latter method, people would need to make sure shred::{ResourceId, Resources, SystemData} are in scope.

bors[bot] commented 5 years ago

Build succeeded