Eliminate safety issue in Resource::downcast* - Githubissues

amethyst / shred

Shared resource dispatcher

Apache License 2.0

233 stars 66 forks source link

Eliminate safety issue in Resource::downcast* #218

Closed torkleyy closed 2 years ago

torkleyy commented 2 years ago

Fixes #217

The previous implementation uses mopa, which has a known safety issue: https://github.com/chris-morgan/mopa/issues/13
This commit essentially inlines the code generated by the mopafy! macro provided by mopa, thus removing the dependency
Since mopa::Any was part of the public interface of the Resource trait, this is technically a breaking change

Thank you to @Cypher1 for reporting this issue

Cypher1 commented 2 years ago

Thanks! Lgtm