Replace TrustCell implementation with atomic_refcell::AtomicRefCell - Githubissues

amethyst / shred

Shared resource dispatcher

Apache License 2.0

233 stars 66 forks source link

Replace TrustCell implementation with atomic_refcell::AtomicRefCell #224

Closed Imberflur closed 1 year ago

Imberflur commented 1 year ago

This PR replaces TrustCell with atomic_refcell::AtomicCell which provides near identical functionality.

Advantages of this change:

atomic_refcell uses an alternative strategy to handle overflows of the read counter which allows for a single atomic operation when acquiring a read guard.
Removing the TrustCell implementation reduces the amount of unsafe code in this crate.

~~Based on top of commits from: https://github.com/amethyst/shred/pull/223~~ ~~Waiting on: https://github.com/bholley/atomic_refcell/pull/18~~