search

amethyst / shred

Shared resource dispatcher
Apache License 2.0
233 stars 66 forks source link

Add missing Send/Sync impls #225

Closed Imberflur closed 1 year ago

Imberflur commented 1 year ago

Forgot these in https://github.com/amethyst/shred/pull/223!

zesterer commented 1 year ago

Miri failure? Hopefully nothing important

Imberflur commented 1 year ago

Miri failure? Hopefully nothing important

This is to be expected for now. MetaTable does some very questionable stuff with vtable pointers. I haven't ran into tests (in specs) that fail Miri due to this yet so I'm not focusing on it (but I would like to have reminder of Miri failing). Unfortunately, github CI lacks ability to have a CI check that is allowed to fail without showing red X https://github.com/orgs/community/discussions/15452. IIRC I think MetaTable is used for potential scripting support.