amethyst / specs

Specs - Parallel ECS
https://amethyst.github.io/specs/
Apache License 2.0
2.49k stars 219 forks source link

Fixes #666 #667

Closed bofh69 closed 4 years ago

bofh69 commented 4 years ago

Checklist

API changes

azriel91 commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build failed

azriel91 commented 4 years ago

Seems like rustc 1.42.0-nightly (a9dd56ff9 2019-12-30) breaks on compiling maxtrixmultiply 0.2.3, which nalgebra 0.19.0 depends on.

error: array lengths can't depend on generic parameters
   --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/matrixmultiply-0.2.3/src/dgemm_kernel.rs:786:44
    |
786 |     let mut ab: [[T; NR]; MR] = [[0.; NR]; MR];
    |                                            ^^

(Likely) related:

Note: It compiles fine on rustc 1.42.0-nightly (0de96d37f 2019-12-19)

azriel91 commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Build succeeded

azriel91 commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build succeeded