Closed xMAC94x closed 2 years ago
Was most of this CI code taken from another Amethyst repo? It looks like it was. Would be curious to see how their CI runs. Also, I feel like there's a way to get CI to run on a fork? I'll try to run this branch on mine and we can see how it does.
I have CI running on my fork, we can check that the changes run there :)
@fhaynes looks like I'll need your perms to make some changes to this repo. We'll need to remove the required status on the continuous-integration/travis-ci
job, and potentially add the requirement to some new jobs after this merges.
Hey,
Let me get to a computer and I will look at this. Probably an hour or two.
Get Outlook for iOShttps://aka.ms/o0ukef
From: Forest Anderson @.> Sent: Tuesday, June 21, 2022 1:45:20 PM To: amethyst/specs @.> Cc: fletcher @.>; Mention @.> Subject: Re: [amethyst/specs] xmac94x/GitHub actions (PR #749)
@fhayneshttps://github.com/fhaynes looks like I'll need your perms to make some changes to this repo. We'll need to remove the required status on the continuous-integration/travis-ci job, and potentially add the requirement to some new jobs after this merges.
— Reply to this email directly, view it on GitHubhttps://github.com/amethyst/specs/pull/749#issuecomment-1162333086, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABBPMFP2HE22DE4VXYVPXMDVQISWBANCNFSM5ZNGDLNQ. You are receiving this because you were mentioned.Message ID: @.***>
@AngelOnFira @xMAC94x I merged this, and sent you an invite to our long-disused gitter. Please drop by if you have a minute, I'd like to know what the goal here is.
Pure CI change, just get rid of travis and go to actions (i hope this works)