Bump shred to 0.14.0 - Githubissues

amethyst / specs

Specs - Parallel ECS

https://amethyst.github.io/specs/

Apache License 2.0

2.49k stars 219 forks source link

Bump shred to 0.14.0 #756

Closed torkleyy closed 2 years ago

torkleyy commented 2 years ago

API changes

Public dependency shred changed
Resources no longer provide mopa::Any trait implementation

Other changes

Bump MSRV to 1.60.0 and test it in CI
Bump edition to 2021
Remove hashbrown dependency

Fixes #746

xMAC94x commented 2 years ago

is there a reason why to remove hashbrown completly ?

torkleyy commented 2 years ago

is there a reason why to remove hashbrown completly ?

Yes, it is no longer necessary. In the Rust 1.36.0 release the std HashMap was replaced by hashbrown's implementation. Source: https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html#a-new-hashmapk-v-implementation

torkleyy commented 2 years ago

Hmm, I just saw they use different hashing algorithms by default. We should consider using a different algorithm than the default (we don't need HashDOS protection).

xMAC94x commented 2 years ago

Hmm, I just saw they use different hashing algorithms by default. We should consider using a different algorithm than the default (we don't need HashDOS protection).

yeah, i had something similar in mind. that stds is crypto-secure by default and we basically dont need that and could go for an algorithm that is very good for hashing of usize (or whatever we need to hash mostly).

Additionally hashbrown has got newer releases since 2019, and i am not sure if we keep udpating std s ones or not

torkleyy commented 2 years ago

r? @xMAC94x

torkleyy commented 2 years ago

Thanks for the reviews @xMAC94x :)