Delete components after killing entities to avoid clearing components when the entity has the wrong generation

amethyst / specs

Specs - Parallel ECS

https://amethyst.github.io/specs/

Apache License 2.0

2.49k stars 219 forks source link

Delete components after killing entities to avoid clearing components when the entity has the wrong generation #766

Closed Imberflur closed 1 year ago

Imberflur commented 1 year ago

Checklist

[x] I've added tests for all code changes and additions (where applicable)
~~[ ] I've added a demonstration of the new feature to one or more examples~~
~~[ ] I've updated the book to reflect my changes~~
~~[ ] Usage of new public items is shown in the API docs~~

API changes

WorldExt::delete_entities method now includes the index of the entity with the wrong generation to indicate to the user where it stopped (since entities after that are not deleted).

zesterer commented 1 year ago

I was about to ping @Imberflur to discuss this, then realised you'd just changed your profile picture :grinning: