Fix #773 - Githubissues

amethyst / specs

Specs - Parallel ECS

https://amethyst.github.io/specs/

Apache License 2.0

2.49k stars 219 forks source link

Fix #773 #774

Closed ClaasJG closed 4 months ago

ClaasJG commented 4 months ago

Hi,

This fixes #773 .

Checklist

[ ] I've added tests for all code changes and additions (where applicable)
[ ] I've added a demonstration of the new feature to one or more examples
[x] I've updated the book to reflect my changes
[ ] Usage of new public items is shown in the API docs

I thought this was already possible based on the resources mentioned in the list above. Therefore, I have not changed anything and don't think anything needs to be added / changed.

-ClaasJG

ClaasJG commented 4 months ago

I added an explanation, that #[storage(...)] accepts storage types with type parameters. English is not my first language and the text feels clunky to me.

ClaasJG commented 4 months ago

Apparently I required one more , for cargo fmt to be happy. I squashed the new format into the first fixing commit which introduced the regression and force pushed to maintain the 3 'clean' commits.

I apologise for the trouble and thank you for your patience with me.

ClaasJG commented 4 months ago

I dont know how to fix the failing check on nightly, nor am I sure, it is caused by this pull request.

Imberflur commented 4 months ago

I dont know how to fix the failing check on nightly, nor am I sure, it is caused by this pull request.

No worries, it isn't caused by this PR.

I'm planning to do some quick testing to confirm works with the new derive logic, and will merge this after I do that.