search

amexabee / My-Portfolio

A portfolio project where you can find detailed description of my most complex and sophisticated projects. Built mainly with HTML and CSS and used JavaScript for some functionalities.
1 stars 0 forks source link

Full display portfolio #4

Closed amexabee closed 2 years ago

amexabee commented 2 years ago

Finish the full version of My Portfolio

Add a contact form in the footer Collect data using the Formspree service Modify HTML code Modify CSS code

amexabee commented 2 years ago

@. I have made the changes to the buttons.  But I don't think I get your point in the first comment. I can see a difference between a light gray background (my design) and whiter background (Figma's). That was because I just used the hex code that was provided by them (#e5e5e5) but I think that was incorrect and so I will use #fff to make it white. But please can you tell me in what other way does my design not resemble Figma's template? And also I don't understand the responsiveness issue can you elaborate on that? Thank you On Wednesday, September 28, 2022 at 12:58:47 PM GMT+3, Cynthia Inga @.> wrote:

@cynthiainga requested changes on this pull request.

Hi @amexabee,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't been addressed yet.

Highlights

Required Changes ♻️

Your design Figma design

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

In index.html:

  • name="name"
  • placeholder="Full Name"
  • maxlength="30"
  • required
  • />
  • <textarea
  • cols="33"
  • rows="3"
  • name="message"
  • placeholder="Enter text here"
  • maxlength="500"
  • required

    • — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>