search

ameya86 / redmine_already_read

Manage issue already read or unread.
10 stars 20 forks source link

Would be nice to have the same functionality also for Activities #3

Open chanibal opened 11 years ago

chanibal commented 11 years ago

Issue highlighting is good, but it seems like the Activity screen could use the same information.

On the Activity screen you can have issues, changesets, wiki edits and timetracking - it would be nice to have them all tracked for viewing of changes.

ameya86 commented 11 years ago

https://github.com/ameya86/redmine_already_read/archive/v0.0.3.tar.gz

chanibal commented 11 years ago

Hi, thanks for the update, unfortunately it has a problem:

Started GET "/projects/.../activity" for ... at Wed Feb 06 15:44:08 +0100 2013
Processing by ActivitiesController#index as HTML
  Parameters: {"id"=>"..."}
  Current user: chanibal (id=3)
Completed 500 Internal Server Error in 83ms

NoMethodError (undefined method `find_events' for AlreadyRead:Module):
  lib/redmine/activity/fetcher.rb:76:in `events'
  lib/redmine/activity/fetcher.rb:75:in `each'
  lib/redmine/activity/fetcher.rb:75:in `events'
  lib/redmine/activity/fetcher.rb:74:in `each'
  lib/redmine/activity/fetcher.rb:74:in `events'
  app/controllers/activities_controller.rb:41:in `index'
ameya86 commented 11 years ago

I dont know "AlreadyRead:Module". AlreadyRead is "class".

please try

grep -R "module AlreadyRead" /redmine/path

chanibal commented 11 years ago

Redmine release is latest stable, after reverting to the old version (0.0.1) of your plugin it works correctly again. Your plugin is the only one currently installed. 

$ grep -R "module AlreadyRead" .
./plugins/redmine_already_read/lib/already_read/query_patch.rb:module AlreadyReadQueryPatch
./plugins/redmine_already_read/lib/already_read/issue_patch.rb:module AlreadyReadIssuePatch

additional system info:

Redmine 2.2.2.stable.11327

Default administrator account changed   (checked)
Attachments directory writable      (checked)
Plugin assets directory writable    (checked)
RMagick available (optional)        (checked)

Environment:
  Redmine version                          2.2.2.stable.11327
  Ruby version                             1.8.7 (i686-linux)
  Rails version                            3.2.11
  Environment                              production
  Database adapter                         MySQL
Redmine plugins:
  redmine_already_read                     0.0.1       // reverted from 0.0.3 after it didn't work
ameya86 commented 11 years ago

Not reproduced my redmine.

chanibal commented 11 years ago

I'll try to look at it again on monday or tuesday, maybe i installed it incorrectly somehow.