search

ameyp / CscopeSublime

A Cscope plugin for Sublime Text 2 and 3
89 stars 37 forks source link

Obligatory 'doesnt work in ST3' issue #20

Closed jamie-pate closed 11 years ago

jamie-pate commented 11 years ago

Tried to use this in ST3 and it doesn't appear to work. (may track issues down later when I have time)

The new goto_definition and goto_symbol_in_project commands don't seem to work very well for some cases (like struct tags etc)

vanrijn commented 11 years ago

Thanks very much for the bug report, Jamie! I haven't actually tried ST3 with CscopeSublime at all yet. Just out of curiosity, what does it do? Does it work at all?

I guess I should get ST3 installed and working enough to start getting CscopeSublime working with it and python3, etc.

Thanks for the heads up! And it goes without saying... patches are always welcome... =;)

julianchurchill commented 11 years ago

In ST3 the Cscope Look up symbol and Look up function definition appear grayed out in the context menu. Highlighting a symbol leaves them grayed out and unsuable. The CScope command do not appear in the command palette at all.

There are a some errors in the console window - here is the first I found:

reloading plugin Cscope.cscope Traceback (most recent call last): File "D:\Program Files\Sublime Text 3\sublime_plugin.py", line 73, in reload_plugin m = importlib.import_module(modulename) File "X/importlib/init.py", line 88, in import_module File "", line 1577, in _gcd_import File "", line 1558, in _find_and_load File "", line 1525, in _find_and_load_unlocked File "C:\Documents and Settings\CHURCHIJ\Application Data\Sublime Text 3\Installed Packages\Cscope.sublime-package\cscope.py", line 38 print "Unable to determine root for: %s" % (self.view.substr(self.view.line(0)))

vanrijn commented 11 years ago

Okay, thanks guys. I'll need to try to find some time soon to play with ST3 and get this plugin working. I've held off until now because A) well, I just don't have much time, and B) when last I tried ST3, there was quite a bit that I rely on working that wasn't working. While A isn't going to improve anytime soon, I'm hoping maybe B has? Also, I'm MORE than willing to look at a pull request if anyone has the time. =:)

vanrijn commented 11 years ago

Okay, we've merged a bunch of fixes into master to support ST3. Can you guys please try this again and let me know if you're still having problems? @julianchurchill and @jamie-pate

Thanks!

jamie-pate commented 11 years ago

LGTM

vanrijn commented 11 years ago

Awesome, thank you @jamie-pate! =:)