search

ameyp / CscopeSublime

A Cscope plugin for Sublime Text 2 and 3
89 stars 37 forks source link

Add rest of cscope lookup modes to commands #23

Closed vanrijn closed 11 years ago

vanrijn commented 11 years ago

Cleaned up command descriptions to be a little more clear. Added ability to search for remaining useful Cscope search types (4, 6, 7, 8). Moved search mode map to global scope so both worker and UI code can use it. Changed CscopeVisiter to handle navigating via a filename line (required for cscope mode 7 but useful for all modes).

I've tested this with all Cscope modes and verified that the functionality is correct and also that the input panel strings matched the output panel strings and also fit the SublimeText command palette strings.

@ameyp Could you look at this when you get a chance please? =:)

ameyp commented 11 years ago

Changes look good, I especially like the way you've cleaned up a lot of hacky code :) I'll accept the pull request, if you want to make the two changes that I suggested, I recommend that you directly make them in the master branch.

Also, if you don't mind, please delete old feature branches.

vanrijn commented 11 years ago

Awesome, thank you @ameyp! I will make the changes you suggested and submit them to master myself. I'll also clean up old feature branches. Thanks again! =:)

ameyp commented 11 years ago

@vanrijn Actually, I just realized that Github lets me delete old branches for merged pull requests right from the web GUI, so I'll just go ahead and do that myself, no need to bother you with it :)

vanrijn commented 11 years ago

Heh. Okay, no worries either way. =:)