ameyp / CscopeSublime

A Cscope plugin for Sublime Text 2 and 3
89 stars 37 forks source link

Appending cscope results buffer to already existing one #25

Closed ageekymonk closed 11 years ago

ageekymonk commented 11 years ago

With this change, the user can append cscope results to any of his existing cscope results buffer. If he wants a new results view, just press ESC key.

ameyp commented 11 years ago

Thanks for the pull request, but two issues come immediately to mind:

  1. The second cscope lookup's symbol is not highlighted (with a white outline) in the results page, only the symbol that was looked up first is highlighted
  2. It isn't self-evident that pressing enter would append results while pressing escape will create a new buffer. I don't know what a good way around this might be, but the current way of just showing an input panel doesn't seem newbie-friendly to me

A third, and relatively minor (and probably specific to me) issue is that I expected the new results to be appended to the existing results and the view to be scrolled to them (as opposed to them being prefixed to the existing results).

If you can fix the first problem and maybe come up with a better solution for the second one, the pull request looks fantastic to me and ripe for a merge. @vanrijn thoughts?

vanrijn commented 11 years ago

To be honest, @ameyp, I don't really like this idea. I think it adds complexity to the code that will just make it harder to port and maintain. And I personally don't think I would ever want this functionality. I always have more than one cscope results tab open and I move in between them. Maybe I'm not understanding the use case for this or why it would be helpful?

ameyp commented 11 years ago

@vanrijn I don't use a lot of IDEs myself, but people use one called "Source Insight" at work, and in it you have the option of appending symbol lookup results to an existing buffer, letting you have a single buffer with different results. I guess it's for people who don't like tabs. Anyway, I tend to agree with you, so I'll just leave the final call to you.

vanrijn commented 11 years ago

Okay, I'm sorry, @ageekymonk, but I'm not going to merge this one in. I hate to do this, but I'm going to close the pull request.