search

ameyp / CscopeSublime

A Cscope plugin for Sublime Text 2 and 3
89 stars 37 forks source link

Adding ST3 Compatibility #28

Closed ageekymonk closed 11 years ago

vanrijn commented 11 years ago

Wow, awesome!! Thank you so much, @ageekymonk!!! I have been meaning to look into this for months now. I will try to look at this more today.

One thing I was hoping was that we could make CscopeSublime compatible with both ST3 and ST2 at the same time so we didn't have to have 2 separate branches. Do you know if your patch will work in both?

It looks like the bulk of the changes are simple python cleanup, right? But the bit at the end where you added a new method... could you help me understand that and why it's necessary?

Thank you again, so much, for this patch!!! =:)

vanrijn commented 11 years ago

Hm. I tried this just now with ST3 and I get this error:

error: Error loading syntax file "Packages/Cscope.sublime-package/Lookup Results.hidden-tmLanguage": Unable to open Packages/Cscope.sublime-package/Lookup Results.hidden-tmLanguage

Also, I get other errors when trying to run this in ST2. I'll create an ST3 branch for this work and check it in as soon as I get around the error above. I'd LOVE to be able to support both ST2 and ST3 from the same branch like a bunch of other plugins do (https://github.com/wbond/sublime_package_control/wiki/Sublime-Text-3-Compatible-Packages), so I'll start working on that next as I get time. Would love help with this too though. =:)

Thank you again, @ageekymonk!!

vanrijn commented 11 years ago

Okay, I think I was seeing this error because I had an old Cscope buffer from ST2 saved in my session and ST3 didn't like it. Pushing up an ST3 branch now. This seems to work well for ST3 from my limited testing. Thank you again, @ageekymonk! If you would be able to help me make the ST3 branch also be able to support ST2, I'd greatly appreciate it and would be able to merge the ST3 branch to master instead of having to keep it separate.

vanrijn commented 11 years ago

Merged this and few cleanups into https://github.com/ameyp/CscopeSublime/tree/ST3

ameyp commented 11 years ago

@vanrijn Nice, perhaps a note could be added to the README to point ST3 users towards the branch?

vanrijn commented 11 years ago

Yeah, good point. Should have done this. Thankfully, master now supports ST2 and ST3, thanks to you and @ageekymonk, @ameyp. =:)

carleeto commented 11 years ago

Hey guys,

I'm on Windows using ST3 and I just saw this error after installing the CScope plugin using Package Control. I have gotten rid of any traces of ST2 on my system. Is there any way I can help diagnose the problem?