ameyp / CscopeSublime

A Cscope plugin for Sublime Text 2 and 3
89 stars 37 forks source link

Fix for configuring cscope path in windows and in linux if needed. #32

Closed ageekymonk closed 11 years ago

ageekymonk commented 11 years ago

Tested in Linux. Do not have a Windows system to test.

vanrijn commented 11 years ago

Sorry for the lengthy silence, @ageekymonk. =:( Looking at this one right now. Thank you!!

vanrijn commented 11 years ago

Awesome, thank you again, @ageekymonk! I had to move the executable get_setting call to the main UI thread. ST2 complained about me calling get_setting() from the worker thread.

@ageekymonk, can you please look this over and try it from master and see if you hit any problems?

@ameyp: this was a nice change, but I wanted to get you to look it over when you get a chance and make sure you're good with it.

Thanks guys! =:)

ameyp commented 11 years ago

Oops, looks like I'm too late to the discussion, sorry. It would be great if the README could be updated to say which flag needs to be set in order to specify the cscope binary path.

ageekymonk commented 11 years ago

@vanrijn, Tried with the master and the change works fine. Tested with ST3.

vanrijn commented 11 years ago

Hey @ameyp! Good idea. I'll do that right now. Hm, actually, the variable is "executable" and the documentation says: 2. Customize the cscope executable path in your user settings file, if needed. I'm not sure how to explain this better. =:/

@ageekymonk Thank you again! =:)

ameyp commented 11 years ago

@vanrijn Yes, but in the user settings file, the variable would have to be called "CscopeSublime_executable", and not just "executable". But then again, clarifying that succinctly in the README might be hard. Perhaps phrase it as:

Customize the cscope executable path as explained in the Configuration section below, if needed.

I'll leave it up to you :)

vanrijn commented 10 years ago

Sorry for not answering for so long. sigh I like your suggestion, @ameyp, and I followed it in README.md. =:) Thanks again!