amezenin / encyclopedia-kn

0 stars 0 forks source link

Not use filed injection #7

Open vahid-forghani opened 2 years ago

vahid-forghani commented 2 years ago

https://github.com/amezenin/encyclopedia-kn/blob/d53e5f3c72c28001a877e8c4e140c8eff7fe7b01/src/main/java/com/knits/product/service/mapper/ArticleMapper.java#L17

It is better to use constructor injection like

    private final CommentMapper commentMapper;

    public ArticleMapper(CommentMapper commentMapper) {
        this.commentMapper = commentMapper;
    }

You can also use lombok and use @RequiredArgsConstructor annotation so you can even remove the constructor and your code would be cleaner like this:

@Component
@RequiredArgsConstructor
public class ArticleMapper {

    private final CommentMapper commentMapper;
amezenin commented 2 years ago

https://github.com/amezenin/encyclopedia-kn/blob/d53e5f3c72c28001a877e8c4e140c8eff7fe7b01/src/main/java/com/knits/product/service/mapper/ArticleMapper.java#L17

It is better to use constructor injection like

    private final CommentMapper commentMapper;

    public ArticleMapper(CommentMapper commentMapper) {
        this.commentMapper = commentMapper;
    }

You can also use lombok and use @RequiredArgsConstructor annotation so you can even remove the constructor and your code would be cleaner like this:

@Component
@RequiredArgsConstructor
public class ArticleMapper {

    private final CommentMapper commentMapper;

Thank you! Fixed.