search

ami-iit / adam

adam implements a collection of algorithms for calculating rigid-body dynamics in Jax, CasADi, PyTorch, and Numpy.
https://adam-docs.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
131 stars 20 forks source link

Split deps #21

Closed Giulero closed 2 years ago

Giulero commented 2 years ago

I want to update the installation procedure for pruning dependencies that the user might not need in this PR. For example, the installation would require PyTorch even if the user just needs the CasAdi interface.

Now the installation would need:

or, if the user does not want to clone the repo:

pip install adam[selected-interface]@git+https://github.com/ami-iit/ADAM

I took also the occasion to change the import syntax. Before:

from adam.casadi.computations import KinDynComputations

After:

from adam.casadi import KinDynComputations

The import syntax used before is still working, so the old code using adam does not need to be updated.

traversaro commented 2 years ago

Given that the version that is currently in master (i.e. after https://github.com/ami-iit/ADAM/pull/20) has been the default one installed if somebody cloned the repo in the last two months, could it make sense to tag it as 0.0.2 and then merge this PR?

Giulero commented 2 years ago

Given that the version that is currently in master (i.e. after https://github.com/ami-iit/ADAM/pull/20) has been the default one installed if somebody cloned the repo in the last two months, could it make sense to tag it as 0.0.2 and then merge this PR?

Sure! I'll update also 5c54e46.

Giulero commented 2 years ago

Thanks @traversaro! Merging.