search

ami-iit / adam

adam implements a collection of algorithms for calculating rigid-body dynamics in Jax, CasADi, PyTorch, and Numpy.
https://adam-docs.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
131 stars 20 forks source link

Required python version #46

Closed jake-levy closed 1 year ago

jake-levy commented 1 year ago

Hello -

Here, you are requiring Python 3.8 or later. https://github.com/ami-iit/ADAM/blob/bffcc3cf1af34a0d28238da9105044f40124d44d/setup.cfg#L28

I was wondering if you would consider changing to >=3.7 instead. I want to use your package with NVIDIA Isaac Sim, which uses Python 3.7.13.

DanielePucci commented 1 year ago

CC @Giulero

Giulero commented 1 year ago

Hi @jake-levy! Thanks for opening the issue. We might change the Python version to 3.7, but in the future, we could be forced to change to an higher version since python 3.7 is reaching its end of life (https://www.python.org/downloads/release/python-370/)!

jake-levy commented 1 year ago

Ah ok; thanks!

Giulero commented 1 year ago

@jake-levy python version changed! https://github.com/ami-iit/ADAM/pull/47

jake-levy commented 1 year ago

Thank you!!