Parametric improvements

ami-iit / adam

adam implements a collection of algorithms for calculating rigid-body dynamics in Jax, CasADi, PyTorch, and Numpy.

https://adam-docs.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

123 stars 19 forks source link

Closed S-Dafarra closed 5 months ago

S-Dafarra commented 6 months ago

Fixes #68 Fixes #69 Fixes #70 Fixes #71

This PR also adds a conversion function from an adam model to an iDynTree model

S-Dafarra commented 6 months ago

Tests are failing because the changes of https://github.com/robotology/idyntree/pull/1160 are not yet available in conda.

S-Dafarra commented 6 months ago

Tests are failing because the changes of robotology/idyntree#1160 are not yet available in conda.

S-Dafarra commented 6 months ago

CI is now happy. The PR is ready to be reviewed. In particular, I would love the comments of:

Giulero commented 6 months ago

During the review, I also figured out that some files are signed with the old license (see #64)

# This software may be modified and distributed under the terms of the
# GNU Lesser General Public License v2.1 or any later version.

I will update them in a different PR.

Giulero commented 5 months ago

Hi @S-Dafarra ! Can we merge the PR? :)

S-Dafarra commented 5 months ago

Hi @S-Dafarra ! Can we merge the PR? :)

Hi @Giulero, there was this point open, but at this point I think we can proceed 😉

traversaro commented 5 months ago

Hi @S-Dafarra ! Can we merge the PR? :)

Hi @Giulero, there was this point open, but at this point I think we can proceed 😉

Sure!

Giulero commented 5 months ago

Thanks a lot! <3 Merging.