search

ami-iit / element_weight-retargeting

0 stars 0 forks source link

Add first version of the WeightRetargetingModule #13

Closed RiccardoGrieco closed 2 years ago

RiccardoGrieco commented 2 years ago

This PR for a review on the implementation of the WeightRetargetingModule.

I left some TODOs which will be addressed in a second moment. Please ignore them.

traversaro commented 2 years ago

Something else that I think it may be worth investigating is to add some initial prefix to all the log messages, so it is easy to distinguish them when they are visualized with the output of several other modules. On this, I guess that the input of @S-Dafarra with his telexistence experience may be useful. Also using "components" of yarp logging could be useful, see https://www.yarp.it//v3.5/yarp_logging.html#autotoc_md811 .

RiccardoGrieco commented 2 years ago

Good work! I made several comments, but nothing blocking.

Thanks @traversaro for the interesting review! I will make sure to address these points before closing the PR.

RiccardoGrieco commented 2 years ago

cc @mebbaid

RiccardoGrieco commented 2 years ago

Something else that I think it may be worth investigating is to add some initial prefix to all the log messages ...

As you suggested, I decided to use the yarp logging component (fc966a9).

@traversaro I addressed your suggestions, please take a look at the new changes!