search

ami-iit / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
0 stars 0 forks source link

Update the icub3/wbd branch to the latest robotology devel #2

Closed GiulioRomualdi closed 3 years ago

GiulioRomualdi commented 3 years ago

This PR should fix #1

Without this PR With this PR
image image
GiulioRomualdi commented 3 years ago

Before merging I would like to wait for https://github.com/robotology/icub-models/issues/68 (it should not affect icub3)

prashanthr05 commented 3 years ago

Let us remove the commits https://github.com/dic-iit/icub-models/commit/acff976074ad84262d92151df0a0a6c5dc3502e2 and https://github.com/dic-iit/icub-models/commit/df289b6039bcafb005365d8aafcbc80d0912a66b from the icub3/wbd branch and merge rebase this branch over devel instead of merging. So we can close this PR.

Or I can add a commit removing specifically the lines added in the above two commits.

What do you think? After the rebase, I will add the changes relevant to XSense IMU instead of Bosch IMU in iCubGenova09 (the only required modification, since other mods have been addressed already).

S-Dafarra commented 3 years ago

Let us remove the commits acff976 and df289b6 from the icub3/wbd branch and ~merge~ rebase this branch over devel instead of merging. So we can close this PR.

Or I can add a commit removing specifically the lines added in the above two commits.

What do you think? After the rebase, I will add the changes relevant to XSense IMU instead of Bosch IMU in iCubGenova09 (the only required modification, since other mods have been addressed already).

Ok for me