search

ami-iit / robot-log-visualizer

Visualizer to display the data logged with YarpRobotLoggerDevice
BSD 3-Clause "New" or "Revised" License
24 stars 5 forks source link

🐛 Fix the robot visualization when the dataset contains signals retrieved at different frequencies #72

Closed GiulioRomualdi closed 1 year ago

GiulioRomualdi commented 1 year ago

This PR addressed #71. The problem identified in #71 was caused by a discrepancy in the data collection frequencies—image signals were captured at 30fps, while joint data was recorded at 100Hz. In this specific dataset, we encountered an unfortunate situation where the initial timestamp of the camera data was lower than the first timestamp of the joints. Consequently, the visualizer erroneously used the camera timestamps as the base timestamp for the entire dataset.

To resolve this issue, the PR introduces a fix that computes the correct time joint index based on the common timestamps used by the visualizer. This ensures proper synchronization and resolves the problems observed in #71.

GiulioRomualdi commented 1 year ago

@paolo-viceconte let me know if you are fine with this PR :)

paolo-viceconte commented 1 year ago

Yes, it loogs good to me. Also given the test mentioned in https://github.com/ami-iit/robot-log-visualizer/issues/71#issuecomment-1812758355, I guess we can merge.