ami-iit / yarp-openmct

Repo for YARP and OpenMCT integration.
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Implement the integration of a telemetry server on YarpJS framework #1

Closed nunoguedelha closed 3 years ago

nunoguedelha commented 3 years ago

(This PR was moved from https://github.com/robotology/yarp.js/pull/21)

This PR implements the integration of a telemetry server on YarpJS for serving Open MCT telemetry visualizer.

We connect the robot interface Yarp ports to the Open MCT via the yarp.js Yarp-to-websocket server are listed below as follows:

nunoguedelha commented 3 years ago

Did a quick test and verified same functionality as in the old repo. Now YarpJS is a dependency.

nunoguedelha commented 3 years ago

@traversaro , the PR is ready for review.

nunoguedelha commented 3 years ago

The code seems nice, but it may be difficult to use especially for someone without a lot of node experience. Do you plan to have a README (also something simple) to explain how to run the code?

Yes absolutely, I have another PR coming with the implementation of all the remaining ports with iCub data, After or with that one I can add a README. The commands for running the telemetry servers and the Client are really simple. I will add a short how-to for adding a port to read.

nunoguedelha commented 3 years ago

Merging ...