ami-iit / yarp-openmct

Repo for YARP and OpenMCT integration.
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Missing plots measurement units: revert workaround #83 when `openmct` fix done. #119

Closed nunoguedelha closed 2 years ago

nunoguedelha commented 2 years ago

Originally posted by @nunoguedelha in https://github.com/ami-iit/yarp-openmct/issues/70#issuecomment-971839012


After cloning the Open-MCT repository and installing tag 1.7.8 (https://github.com/ami-iit/yarp-openmct/issues/81#issuecomment-971828190), I did some tests, importing a sample of the iCubTelemetry JSON dictionary as shown below, and noticed that the measurement units are still missing.

Test JSON dictionary ```json { "openmct":{ "0b0eae16-ac42-411c-8e23-ac392ddc3908":{ "composition":[], "identifier": { "namespace": "yarpopenmct.telemetry", "key": "sens.imu" }, "name": "iCub Telemetry", "type": "icubsensor.telemetry", "telemetry": { "values": [ { "key": "value.ori.roll", "name": "Roll", "units": "degrees", "format": "float", "hints": { "range": 1 } }, { "key": "utc", "source": "timestamp", "name": "Timestamp", "format": "utc", "hints": { "domain": 1 } } ] } } }, "rootId":"0b0eae16-ac42-411c-8e23-ac392ddc3908" } ```

So, while we wait for a fix from Open-MCT team, we will implement a simple workaround consisting in appending the units directly to the axis name.


We wish to remove the workaround as soon as the fix nasa/openmct#4159 is merged in the original NASA repository or openmct#6 is merged in the fork.