ami-iit / yarp-openmct

Repo for YARP and OpenMCT integration.
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Feature request: signals to be logged #121

Closed S-Dafarra closed 1 year ago

S-Dafarra commented 2 years ago

In order to improve the usability of the framework, I think it would be important to add this set of data to be logged:

This is the list of things we are currently logging for offline testing. Reference code: https://github.com/ami-iit/bipedal-locomotion-framework/tree/dc113093d2467e854a2b1427265af55f559f13d0/devices/YarpRobotLoggerDevice

Let me remark that this data might be robot-dependent. For example, the lists of FTs and cartesian_wrenches depend on the robot.

Moreover, we might need to add more data in the future.

cc @nunoguedelha @traversaro

S-Dafarra commented 2 years ago

It might also be useful to log the text log coming from the modules. In general anyway, it would be nice to have a shared interface between the online and offline logging.

cc @GiulioRomualdi

GiulioRomualdi commented 2 years ago

For the TextLogging I took inspiration from what is done in YarpManager. https://github.com/ami-iit/bipedal-locomotion-framework/pull/546

nunoguedelha commented 2 years ago

For the TextLogging I took inspiration from what is done in YarpManager. ami-iit/bipedal-locomotion-framework#546

@GiulioRomualdi , I guess you meant more specifically https://github.com/ami-iit/bipedal-locomotion-framework/pull/541.

nunoguedelha commented 2 years ago

@S-Dafarra , I've added the following bullets/issues in the description according to your comments:

nunoguedelha commented 2 years ago

@S-Dafarra , I had already added #133 to this epic, and just added it to the issue description.

Also added the issue #139 fixing the problems we ran into during the last test session on Friday.

nunoguedelha commented 1 year ago

Since #137 is in Backlog and not the top priority right now, I'm moving it out of the Epic for being able to close it.

nunoguedelha commented 1 year ago

If it's ok with you @S-Dafarra , I would close this Epic.

S-Dafarra commented 1 year ago

I agree. Great work!