ami-iit / yarp-openmct

Repo for YARP and OpenMCT integration.
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Tentative fix issue: refreshing page breaks realtime socket #166

Closed nunoguedelha closed 1 year ago

nunoguedelha commented 1 year ago

Fixes #147 .

This is a tentative fix.

S-Dafarra commented 1 year ago

Merging!

nunoguedelha commented 1 year ago

@S-Dafarra , just a minor suggestion...

in order to have a linear history, more readable, and in the case of small increments of code (should usually be the case in continuous integration and good code practice), I suggest you avoid merge commits. After the branch is ready for merge, you can get such result as follows (you probably already know this, so sorry if this is redundant):

then just clean the branch locally and remotely. Always remember to have the master branch protected in your repos (already the case here a priori).

S-Dafarra commented 1 year ago

Thanks a lot for the suggestion!