Run iCub telemetry server and openMCT visualizer in one line command: Iteration 2/2

nunoguedelha commented 3 years ago

Implements #25 . (iteration 2/2)

nunoguedelha commented 3 years ago

The child process running the openmctStaticServer is already properly launched by the iCubTelemVizServer, such that we run everything by running "npm start" in the openmctStaticServer folder. But stopping the servers or aborting is still not working properly, I'm still working on it.

nunoguedelha commented 3 years ago

I've implemented a small improvement/simplification for handling the Node.js versions.

[x] Enhancement: we select the Node.js version in the openmctStaticServer start script instead of using a child process of iCubTelemVizServer (execSync command from the child_process package). Run both telemetry server and openmct visualizer Node.js applications through a single command #25 (comment), Run iCub telemetry server and openMCT visualizer in one line command: Iteration 2/2 #32 .

On top of that, the fix for properly closing the servers will be tracked in #34 , refer to https://github.com/ami-iit/yarp-openmct/issues/25#issuecomment-925238775.

So, I would consider the work complete here.

nunoguedelha commented 3 years ago

This actually simplifies the documentation. The README will be updated in #22 where also tracked the other feedback from @traversaro .

nunoguedelha commented 3 years ago

Hi @S-Dafarra , I'm adding you as a reviewer for avoiding to load @traversaro with this.

ami-iit / yarp-openmct

Run iCub telemetry server and openMCT visualizer in one line command: Iteration 2/2 #32