Bunch of updates

[iamdamosuzuki]

I added tons of filters and fixed up other ones that were screwy. I'm sure there's typos and stuff everywhere but the echo filter is WORKING SO WELL. Can someone just make sure I'm not destroying someone else's work with this?

[bturkus]

I plan to play with everything tomorrow!

Sent from my iPhone

On Oct 20, 2020, at 7:24 PM, Morgan Oscar Morel notifications@github.com wrote:

 I added tons of filters and fixed up other ones that were screwy. I'm sure there's typos and stuff everywhere but the echo filter is WORKING SO WELL. Can someone just make sure I'm not destroying someone else's work with this?

You can view, comment on, or merge this pull request online at:

https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4

Commit Summary

fixed chromakey, i was using colorkey lol fixed default values got the echo/feedback loop working, blend modes are still wrong used andrews suggestion of normal blend mode with lowered opacity to get some great effects created lagfun and added modes to echo. echo is great now File Changes

M bash_scripts/chromakey.sh (4) A bash_scripts/convolve.sh (10) A bash_scripts/echo.sh (80) A bash_scripts/lagfun.sh (39) M bash_scripts/tblend.sh (2) Patch Links:

https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4.patch https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[nkrabben]

Any opinions on making all arguments named parameters, like this ./blend.sh -v1 path/to -v2 path/to -mode selection instead of positional arguments like this ./blend.sh path/to path/to selection ?

Personally i like having named parameters if only for the teaching value of having people associate inputs with what the script is doing. Also, they're easier for me to code with.

On Tue, Oct 20, 2020 at 8:00 PM bturkus notifications@github.com wrote:

I plan to play with everything tomorrow!

Sent from my iPhone

On Oct 20, 2020, at 7:24 PM, Morgan Oscar Morel < notifications@github.com> wrote:

 I added tons of filters and fixed up other ones that were screwy. I'm sure there's typos and stuff everywhere but the echo filter is WORKING SO WELL. Can someone just make sure I'm not destroying someone else's work with this?

You can view, comment on, or merge this pull request online at:

https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4

Commit Summary

fixed chromakey, i was using colorkey lol fixed default values got the echo/feedback loop working, blend modes are still wrong used andrews suggestion of normal blend mode with lowered opacity to get some great effects created lagfun and added modes to echo. echo is great now File Changes

M bash_scripts/chromakey.sh (4) A bash_scripts/convolve.sh (10) A bash_scripts/echo.sh (80) A bash_scripts/lagfun.sh (39) M bash_scripts/tblend.sh (2) Patch Links:

https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4.patch https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iamdamosuzuki/ffmpeg-artschool/pull/4#issuecomment-713207876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2XZP7JVE3NN4RBB53OFXTSLYQCTANCNFSM4SZAEAZA .

--

Nick Krabbenhoeft Digital Preservation Manager Digital Research Division

Library Services Center

The New York Public Library 31-11 Thomson Avenue, Long Island City, NY 11101 917.229.9596 | x39596 nypl.org

[bturkus]

@nkrabben regarding the named parameters question, when you say "easier to code with," do you mean easier to transform to powershell?

[nkrabben]

also read and understand what's happening.

there's a couple for loops where the $3 from the args becomes the $1 in the for loop, which takes me a bit to parse.

[bturkus]

I tested everything today and I think it all worked well enough to merge, Nick's small comments and larger question notwithstanding. For me, it'll be easier to continue that convo separately and do a full once-over for small things; hope that's okay with everyone. Love it all Morgan!