amiaopensource / ffmprovisr

Repository of useful FFmpeg commands for archivists!
https://amiaopensource.github.io/ffmprovisr/
520 stars 65 forks source link

Another attempt at fade in/out documentation #428

Closed DaleLore closed 4 years ago

DaleLore commented 4 years ago

Hopefully I got all the uses of "frames" out. (Let me know if one snuck in) And I tried to be more specific by using the example that was used in the stackoverflow forum.

This is for Issue: OG #386 / First attempt #422 / Now this attempt #424

kfrn commented 4 years ago

Thanks, @DaleLore!

I wonder if we should make it even more generic? e.g.

-filter:v "fade=in:st=IN_POINT:d=DURATION, fade=out:st=OUT_POINT:d=DURATION" \
   -filter:a "afade=in:st=IN_POINT:d=DURATION, afade=out:st=OUT_POINT:d=DURATION"

With a note like:

And then maybe your specific example in the notes?

Or am I getting too finicky here 🤔😀

kieranjol commented 4 years ago

@kfrn - Not too finicky - I think the 44.1kHz should be removed to make it more generic. And i think just using the variables that @kfrn mentions would maybe be the best solution.

I've seen folks get confused by hardcoded values before when trying to scale it to their own use case.

retokromer commented 4 years ago

I agree with @kfrn and @kieranjol. On our internal website – of which many parts are publicly accessible – in some of our recipe we have a hard-coded version and the generic version of the commands. We made good experience with. Could this be a solution?

kfrn commented 4 years ago

I've seen folks get confused by hardcoded values before when trying to scale it to their own use case.

This is key, I think!

@DaleLore, did you want to update the PR? I'm also happy to make that change if you'd prefer.

ablwr commented 4 years ago

Thanks @DaleLore and everybody for taking this the extra mile!!

retokromer commented 4 years ago

Thank you @DaleLore !

kieranjol commented 4 years ago

Yay, thanks @dalelore et al