amiaopensource / ffmprovisr

Repository of useful FFmpeg commands for archivists!
https://amiaopensource.github.io/ffmprovisr/
527 stars 65 forks source link

Troubleshooting Section Addition #472

Closed aln363 closed 1 month ago

aln363 commented 9 months ago

This fork comes out of a final project for NYU MIAP's digital literacy course, it is designed for beginner archivists using ffmpeg who may encounter errors they don't know how to solve.

ablwr commented 9 months ago

This is looking really really good to me! I think this is going to be super helpful for people diving into FFmpeg for the first time, and I really appreciate the "new user's perspective" that this brings.

Overall, I don't have any larger structural comments, I think this looks good. Other maintainers, what do you think?

I see a couple of "nits" (very minor typo issues) and I'll address those comments in a code review.

ablwr commented 9 months ago

Trial by fire! Thank you SO much for this contribution and don't take my comments negatively, I'm thrilled to see this contribution!

privatezero commented 8 months ago

Circling back to this! @aln363 - did you have a chance to look at @ablwr comments?

retokromer commented 7 months ago

Ping @aln363 : I’d like to open a few PRs that might conflict with yours. That’s why I would be happy if this could be finalised.

kfrn commented 7 months ago

Hi team! Where are we at with this PR currently? I was going to make some time to review, but I see that there are already a bunch of pending comments. @aln363, how are things looking at your end? :relaxed:

retokromer commented 6 months ago

ping

privatezero commented 1 month ago

Closing this - feel free to reopen in future if ready to merge