Refactored Grabbags to include a runner class that encapsulates successes, failures, and not_a_bag

amiaopensource / grabbags

grabbags is an enhanced usage of the LOC bagit Python Library

GNU General Public License v3.0

11 stars 8 forks source link

Refactored Grabbags to include a runner class that encapsulates successes, failures, and not_a_bag #63

Closed henryborchers closed 3 years ago

pep8speaks commented 3 years ago

Hello @henryborchers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file grabbags/grabbags.py:

Line 503:5: E303 too many blank lines (2)

In the file tests/test_grabbags.py:

Line 928:80: E501 line too long (102 > 79 characters)

Comment last updated at 2021-07-26 22:10:25 UTC

henryborchers commented 3 years ago

This should have exactly no changes in terms of the functionality. The code, on the other hand, should be much easier to maintain.

henryborchers commented 3 years ago

@jfarbowitz @milothiesen Any chance you could check out this PR and try it out?

This has one of the missing parts I need to make the GUI report the correct results after running a bagging process more than once. Otherwise the the application would have to be restarted between each job to correctly report the number of bags were successful.

henryborchers commented 3 years ago

Anybody we should add to review this code?

jfarbowitz commented 3 years ago

Not that i can think of other than me and Milo

Jonathan

On Mon, Jul 26, 2021 at 6:11 PM Henry Borchers @.***> wrote:

Anybody we should add to review this code?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amiaopensource/grabbags/pull/63#issuecomment-887061980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5S2ZIPF7MK6GE2BOLPI3TZXMRVANCNFSM43D3BN5Q .

henryborchers commented 3 years ago

@jfarbowitz Check out the pull request and give it a try on your own materials.