search

amiaopensource / homebrew-amiaos

Homebrew tap for AMIA Open Source
MIT License
29 stars 14 forks source link

vrecord: upgrade gtkdialog #350

Closed retokromer closed 1 year ago

retokromer commented 1 year ago

Works on my end on macOS 12.6.5 with AArch64 (Apple M1).

dericed commented 1 year ago

There doesn't seem to be any upgrade in this pr. At the moment, vrecord is dependent on the gtkdialog formula from the amiaopensource tap and this pr simply seem to let homebrew decide which gtkdialog formula to use rather than clarify our tap. IMO this makes the installer vulnerable to being inconsistent with selection of gtkdialog formula. Am I missing something?

privatezero commented 1 year ago

Sorry - I don't have an M1 machine to test on. This works on my mac, but I also haven't been able to reproduce the recent issue so I don't think that success on my end gives much information!

retokromer commented 1 year ago

@dericed You are correct, my wrong. I opened a new PR