search

amiaopensource / homebrew-amiaos

Homebrew tap for AMIA Open Source
MIT License
29 stars 14 forks source link

Can't install bmdtools from brew #374

Open burnbrigther opened 8 months ago

burnbrigther commented 8 months ago

Sonoma 14.2.1 MBP M1 - 32GB RAM

ME@MINE ~ % brew install bmdtools ==> Fetching amiaopensource/amiaos/bmdtools ==> Downloading https://github.com/lu-zero/bmdtools/archive/v0.2.tar.gz Already downloaded: /Users/ME/Library/Caches/Homebrew/downloads/530e6e7715bdb0fad49ef1573286e98df72d96204cb3baf0dc880fd6781f4064--bmdtools-0.2.tar.gz ==> Installing bmdtools from amiaopensource/amiaos ==> make SDK_PATH=/opt/homebrew/opt/decklinksdk/include Last 15 lines from /Users/kscholtens/Library/Logs/Homebrew/bmdtools/01.make: snprintf(oc->filename, sizeof(oc->filename), "%s", g_videoOutputFile); ~~ ^ bmdcapture.cpp:883:39: error: no member named 'filename' in 'AVFormatContext' snprintf(oc->filename, sizeof(oc->filename), "%s", g_videoOutputFile); ~~ ^ bmdcapture.cpp:908:36: error: no member named 'filename' in 'AVFormatContext' if (avio_open(&oc->pb, oc->filename, AVIO_FLAG_WRITE) < 0) { ~~ ^ bmdcapture.cpp:909:58: error: no member named 'filename' in 'AVFormatContext' fprintf(stderr, "Could not open '%s'\n", oc->filename); ~~ ^ 11 errors generated. make: [bmdplay] Error 1 make: Waiting for unfinished jobs.... make: *** [bmdcapture] Error 1

If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core): https://github.com/amiaopensource/homebrew-amiaos/issues

dericed commented 8 months ago

Thanks. I see that brew has removed the installer for libav since it's not supported upstream. bmdtools requires libav but also the repository seems inactive for the last 5 years. I'm tempted to resolve this issue by ending support for the bmdtools installer as I think managing these issues without upstream maintain will only become significantly more challenging. @privatezero, thoughts on this?

privatezero commented 8 months ago

@dericed I'd agree - not much we can realistically do to support install in the future if everything upstream is what is actually causing the issues

dericed commented 8 months ago

ok, let's consider dropping support after the next vrecord release and when https://github.com/amiaopensource/vrecord/pull/770 is resolved.

privatezero commented 8 months ago

Sounds good - relatedly I had time today to put a few more comments/clarifications for requested changes in https://github.com/amiaopensource/vrecord/pull/770