delete `require "formula"`

amiaopensource / homebrew-amiaos

Homebrew tap for AMIA Open Source

MIT License

29 stars 14 forks source link

delete `require "formula"` #39

Closed retokromer closed 7 years ago

retokromer commented 7 years ago

If I’m not completely wrong, since some time now the require "formula" statement in the beginning is not longer needed. Should I remove it from the ones that still have it? The current situation is:

[ ] audiorecorder.rb
[x] bmdtools.rb
[x] deckcontrol.rb
[x] decklinksdk.rb
[ ] digibase.rb
[x] ffmprovisr.rb
[ ] ltopers.rb
[ ] mkvparse.rb
[ ] pbprotracktor.rb
[x] qcli.rb
[x] qctools.rb
[x] qwt-qt5.rb
[ ] vrecord.rb

Id est six formulae to be modified and seven already fine.

privatezero commented 7 years ago

That makes sense to me! I just tested the audiorecorder formula with brew audit and can confirm that homebrew doesn't complain about a lack of require formula.

retokromer commented 7 years ago

Thank you, @privatezero! I opened a PR, but only on three formulae, because I did a some mistake and merged directly three formulae…

I don’t think there is any need to add a revision here, as nothing on the behaviour has been modified.

retokromer commented 7 years ago

Resolved by https://github.com/amiaopensource/homebrew-amiaos/pull/40.