search

amiaopensource / ltopers

Bash scripts to manage LTO cartridges with LTFS
https://github.com/amiaopensource/ltopers
MIT License
39 stars 8 forks source link

no `.DS_Store` onto external storage #104

Closed retokromer closed 7 years ago

retokromer commented 7 years ago

should resolve https://github.com/amiaopensource/ltopers/issues/96#issuecomment-301488593

cc @BleakleyMcD

dericed commented 7 years ago

This might cause redundancy. It looks like it runs every time even if it's not needed.

retokromer commented 7 years ago

Yes, it runs every time. Of course, we can check the value before and set the variable only if false, but it will take more time to run. And it should be set back to the original state after running, as well.

retokromer commented 7 years ago

@dericed Now it should overwrite only false with true.

dericed commented 7 years ago

Does that test work without quotes. If the key/value is not set the sdtout of the test would be null and I'd except the condition to fail.

retokromer commented 7 years ago

This way it works also when I delete completely the variable on my computer, i.e. if macOS is corrupt.