search

amiaopensource / ltopers

Bash scripts to manage LTO cartridges with LTFS
https://github.com/amiaopensource/ltopers
MIT License
39 stars 8 forks source link

add test #108

Closed retokromer closed 7 years ago

retokromer commented 7 years ago

Calls renameschemas only if has been installed. Does this resolve https://github.com/amiaopensource/ltopers/issues/105?

privatezero commented 7 years ago

That would seem to work, but I have only used ltopers in the CUNY context, so I can't vouch for how it would operate without the renameschemas call!

retokromer commented 7 years ago

Thank you!

(I cannot check it right now, because I don’t have access to an LTO desk. Without the test, it crashes… but it might crash also with… ;-)

retokromer commented 7 years ago

@privatezero What about moving renameschemas to the general functions? This way it caches also naming conflicts, but does not use a DB.

privatezero commented 7 years ago

that sounds like it would work!

retokromer commented 7 years ago

Done. I also guess it’s better if I put all https://github.com/amiaopensource/ltopers/blob/c2e8e1cfb84dff3ad5b17987a21dcc4ea3045460/writelto#L120_L133 into

if [[ "${PREMIS_DB}" = "Y" ]] ; then
    . . .
fi

There are tests in the single mm functions, but is useless to call them all and return back. Thoughts?

privatezero commented 7 years ago

that seems to make sense to me! In that case, it would also encompass the other db call at: https://github.com/amiaopensource/ltopers/blob/c2e8e1cfb84dff3ad5b17987a21dcc4ea3045460/writelto#L100

retokromer commented 7 years ago

Thank you! Now all seems fine to me.