search

amiaopensource / ltopers

Bash scripts to manage LTO cartridges with LTFS
https://github.com/amiaopensource/ltopers
MIT License
39 stars 8 forks source link

remove _run_critical_event call #171

Closed privatezero closed 6 years ago

privatezero commented 6 years ago

This should revert and resolve issue in https://github.com/amiaopensource/ltopers/issues/170 of writelto erroneously exiting on rsync error.

privatezero commented 6 years ago

I'll make a new release later today to integrate this if there are no objections!

retokromer commented 6 years ago

I was going to propose this during the weekend, therefore full support from my side.

retokromer commented 6 years ago

Possibly https://github.com/amiaopensource/ltopers/issues/169 should be resolved before, as I presume that this could be done quickly.

privatezero commented 6 years ago

Makes sense - holding off for the weekend works for me!

privatezero commented 6 years ago

Hi! Since there doesn't seem to have been any movement so far on https://github.com/amiaopensource/ltopers/issues/169, and the bug that was fixed in this PR could seriously interfere with aspects of LTOpers (at least in making it look like a valid tape write was invalid) I propose we make a new LTOpers release over the weekend in the interest of safe usage.

dericed commented 6 years ago

I'd prefer a release as well. I don't consider #169 as blocking.

retokromer commented 6 years ago

At least a part has been resolved in https://github.com/amiaopensource/ltopers/pull/173.

retokromer commented 6 years ago

Created a new release and updated the formula.