nicer regex - Githubissues

amiaopensource / ltopers

Bash scripts to manage LTO cartridges with LTFS

https://github.com/amiaopensource/ltopers

MIT License

39 stars 8 forks source link

Closed retokromer closed 5 years ago

retokromer commented 5 years ago

This is a more elegant regex, I guess.
Should I change also in the other scripts, in order to check lossier as well? See https://github.com/amiaopensource/ltopers/pull/190#issuecomment-456477695.

retokromer commented 5 years ago

No, my bad, this matches probably [A-Z0-9]{7} as well…

retokromer commented 5 years ago

This should be fine for the lossy variant:

\b[A-Z0-9]{6}(?:[A-Z0-9]{2})?\b

but it’s not really a more elegant regex…

retokromer commented 5 years ago

Or shorter (and harder to maintain ;-)

\b(?:[A-Z0-9]{2}){3,4}\b