search

amiaopensource / vrecord

Vrecord is open-source software for capturing a video signal and turning it into a digital file.
https://github.com/amiaopensource/vrecord
155 stars 45 forks source link

swap bmdcapture to ffmpeg #189

Closed dericed closed 6 years ago

dericed commented 7 years ago

Since we have https://github.com/amiaopensource/homebrew-amiaos/blob/master/ffmpegdecklink.rb, I'm looking at swapping bmdcapture with ffmpeg. This seems to give an opportunity for a lot of cleaning since vrecord could drop one tool from the process. Also the decklink demuxer sets a lot of metadata that vrecord has to assert manually.

I was hoping to add an option to allow the user to switch between a bmdcapture and ffmpeg input, but am worried that maintaining both at once will be difficult. Any opinion on a swap rather than simultaneous support?

kieranjol commented 7 years ago

Is anything in bmdtools that isn't in ffmpeg/decklink? I think this could make ffmpeg more cross platform friendly so I'm very much in favour of a swap.

retokromer commented 7 years ago

I am in favour of a swap as well.

dericed commented 7 years ago

bmdtools supports 32 bit audio via the decklink input and ffmpeg doesn't (patch presently in ffmpeg-devel). I think that's it, but uncertain.

retokromer commented 7 years ago

I have seen your patch, which BTW LGTM.

privatezero commented 7 years ago

Has anyone done any testing to confirm that using the ffmpeg decklink device doesn't introduce any artifacts into the recording vs using bmdcapture? (Just thinking of my inexplicable problems with dropped samples when I tried to integrate the ffmpeg avfoundation device into audiorecorder).

bturkus commented 7 years ago

I think is awesome! Thanks Dave. And I'd be happy to test, but might some help installing and such.

On Tue, Oct 17, 2017 at 1:59 PM, Andrew Weaver notifications@github.com wrote:

Has anyone done any testing to confirm that using the ffmpeg decklink device doesn't introduce any artifacts into the recording vs using bmdcapture? (Just thinking of my inexplicable problems with dropped samples when I tried to integrate the ffmpeg avfoundation device into audiorecorder).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amiaopensource/vrecord/issues/189#issuecomment-337312066, or mute the thread https://github.com/notifications/unsubscribe-auth/AIkiXqG03Suhc0OtvNcl-8-1rv8ACetFks5stOrygaJpZM4P8c5S .

--

Benjamin Turkus | The New York Public Library Assistant Manager for Audio and Moving Image Preservation

Barbara Goldsmith Preservation Division 40 Lincoln Center Plaza, New York, NY 10023 T. 212.870.1609 <(212)870-1609> | benjaminturkus@nypl.org http://www.nypl.org/preservation https://twitter.com/NYPLPreserve

Lifelong Learning | Advancing Knowledge | Strengthening Our Communities

dericed commented 7 years ago

You can test it via: https://github.com/amiaopensource/vrecord/pull/190

retokromer commented 6 years ago

I guess, this has been resolved in v2017-12-15.