amiaopensource / vrecord

Vrecord is open-source software for capturing a video signal and turning it into a digital file.
https://github.com/amiaopensource/vrecord
149 stars 44 forks source link

vrecord installation issue #722

Closed jimhone closed 2 years ago

jimhone commented 2 years ago

While trying to install record using Homebrew, I consistently get the following message:

Installing dependencies for amiaopensource/amiaos/vrecord: amiaopensource/amiaos/ffmpegdecklink, bash and luajit-openresty ==> Installing amiaopensource/amiaos/vrecord dependency: amiaopensource/ami Error: An exception occurred within a child process: NameError: undefined local variable or method `os' for #

Running MAC OS 12.12.1 Latest driver for Blackmagic Desktop Video Setup (12.2.2) ffmpeg version 4.4-with-options

Installing with "--ignore dependencies" results in sluggish startup, setup and near instantaneous exit when I hit record.

Any insights or possible fixes would be appreciated.

dericed commented 2 years ago

Thanks @jimhone. @privatezero and I were trying to resolve this as it's a regression since https://github.com/amiaopensource/homebrew-amiaos/pull/310/files.

retokromer commented 2 years ago

On my end, https://github.com/amiaopensource/homebrew-amiaos/pull/315 fixes it.

privatezero commented 2 years ago

Hi @retokromer it seems that we might be dealing with a couple of separate issues here - on my end both the current formula as well as https://github.com/amiaopensource/homebrew-amiaos/pull/315 fail to build with the error:

NameError: undefined local variable or method `os' for #

This is fixed by changing the method of OS check along the lines of what is in https://github.com/amiaopensource/homebrew-amiaos/tree/fix-system-check

This lets everything build correctly on my end (Ubuntu 20.04) but seems to still have a separate problem on the macOS side - is this what the file name change in https://github.com/amiaopensource/homebrew-amiaos/pull/315 fixes? I am unfortunately unable to test on macOS right now.

retokromer commented 2 years ago

@privatezero I should have the time to run a test tomorrow on Debian 11.1 and macOS 12.2.1 (AArch64).

privatezero commented 2 years ago

@retokromer I think I just actually identified the OS check issue - there was a spot where there was a check written as if os.mac? instead of if OS.mac? - but since that has been removed in the version rollback @dericed just did I suppose that is all worked out as well

privatezero commented 2 years ago

@jimhone we've rolled back the version of the dependency causing issue for now - if you run brew update and try reinstalling, things should be working now!

retokromer commented 2 years ago

@privatezero Indeed! That’s to enable neon.

jimhone commented 2 years ago

Reinstall went smoothly. I'm about 40 minutes into an 85 minute capture and things are looking good. If there are any further issues, I'll let you know.

Many thanks for your help.

jimhone commented 2 years ago

Success!