search

amiaopensource / vrecord

Vrecord is open-source software for capturing a video signal and turning it into a digital file.
https://github.com/amiaopensource/vrecord
151 stars 45 forks source link

Change audio device parsng #754

Closed privatezero closed 1 year ago

privatezero commented 1 year ago

This changes how vrecord parses the output of arecord to find capture device numbers for ffmpeg. Should address the issue in https://github.com/amiaopensource/vrecord/issues/753.

Currently the _get_audio_dev_num compares AUDIO_DEV_CHOICE to AUDIO_DEVICES in a convoluted manner - this was done with the hope of ultimately parsing the displayed audio devices in the GUI differently to make things a little more visually appealing.

For the time being though, the device list in the GUI needs to be the same as the device list on the back end to facilitate saved settings displaying as selected in the GUI, so leaving as-is in the interests of resolving the parsing issue.

privatezero commented 1 year ago

@amiaopensource/vrecord-maintainers does this look ready to merge?