search

amiaopensource / vrecord

Vrecord is open-source software for capturing a video signal and turning it into a digital file.
https://github.com/amiaopensource/vrecord
151 stars 45 forks source link

Audio Passthrough Keybinding toggle doesn't work #782

Open marshalleq opened 8 months ago

marshalleq commented 8 months ago

Other key bindings do, including volume adjustment, but this one does not. Anyone else have it working? Supposedly just pressing a will toggle it right? I need to turn it off as I do other things on this machine and it's getting in the way.

privatezero commented 8 months ago

@marshalleq the audio passthrough mode started by running vrecord -a is basically just a quick way to get vrecord to fire up into the "Audio + Video" preview window - could you confirm what mode you are running and how it isn't working?

marshalleq commented 8 months ago

I'm just running vrecord with no config options (I guess some were saved previously). After I've started recording there are a number of keybindings I can use, one of which is the a key, shown on the on screen display. My expectation is that I can press that to mute the audio being passed through from the source. This would be useful as I actually have meetings at the same time on the same machine and it can be distracting not being able to mute it. Probably not that many archivists do this quite like this, but machines are so powerful now. Of course there are other reasons one would want to mute it also.

privatezero commented 8 months ago

Thanks for clarifying! The vrecord preview window uses ffplay, so it is limited to the commands available to ffplay. Using m during passthrough seems to be working for muting on my system - does this not work while you are capturing?

marshalleq commented 8 months ago

Hmmm, interesting, I was going from the below, (see OSD screenshot), which does not have an m option, though I've now confirmed that does work. So what is the 'a' option for? Is this just out of date, or does it stop audio going to the recording? A few others seem to do nothing also.

Thanks.

Screenshot 2024-02-01 at 13 03 20
privatezero commented 8 months ago

Ah - you are running in 'Quality Control' view - that's actually a bit different from how the other views work. QC View uses mpv rather than ffplay for the window which is what gives it a bit more interactivity. But yes, it was a bit of a work in progress I think so some of the options might not actually be functional which is why a isn't doing anything.

The audio mode that can be started either with vrecord -a or by selecting it in the settings (Audio + Video) basically is just a view that adds in some audio scopes like in this image. It used to be referred to as 'Audio Passthrough' as it was only available in passthrough mode, so that's probably why the broken toggle in QC View is named like that.