Closed dnzmarcio closed 3 years ago
Yes, broom::tidy stores all parameters. It should not create any issues because it will not change the variable grp
for other class objects.
I ran the tests below.
devtools::check()
# Updating mice documentation
# Loading mice
# Writing NAMESPACE
# Writing NAMESPACE
# -- Building ------------------------------------------ mice --
# Setting env vars:
# * CFLAGS : -Wall -pedantic -fdiagnostics-color=always
# * CXXFLAGS : -Wall -pedantic -fdiagnostics-color=always
# * CXX11FLAGS: -Wall -pedantic -fdiagnostics-color=always
# --------------------------------------------------------------
# √ checking for file 'M:\R-packages\mice/DESCRIPTION' (690ms)
# - preparing 'mice': (1m 26.3s)
# √ checking DESCRIPTION meta-information ...
# - cleaning src
# - installing the package to process help pages (784ms)
# - saving partial Rd database (32.7s)
# - cleaning src
# - checking for LF line-endings in source and make files and shell scripts (927ms)
# - checking for empty or unneeded directories
# Removed empty directory 'mice/vignettes'
# - building 'mice_3.13.7.tar.gz'
#
# -- Checking ------------------------------------------ mice --
# Setting env vars:
# * _R_CHECK_CRAN_INCOMING_REMOTE_: FALSE
# * _R_CHECK_CRAN_INCOMING_ : FALSE
# * _R_CHECK_FORCE_SUGGESTS_ : FALSE
# * NOT_CRAN : true
# -- R CMD check -----------------------------------------------
# - using log directory 'C:/Users/dinizma/AppData/Local/Temp/RtmpADNDSH/mice.Rcheck' (577ms)
# - using R version 4.0.3 (2020-10-10)
# - using platform: x86_64-w64-mingw32 (64-bit)
# - using session charset: ISO8859-1
# - using options '--no-manual --as-cran' (684ms)
# √ checking for file 'mice/DESCRIPTION'
# - checking extension type ... Package
# - this is package 'mice' version '3.13.7'
# - package encoding: UTF-8
# √ checking package namespace information ...
# √ checking package dependencies (1.4s)
# √ checking if this is a source package ...
# √ checking if there is a namespace
# √ checking for executable files (5s)
# √ checking for hidden files and directories ...
# √ checking for portable file names ...
# √ checking serialization versions ...
# √ checking whether package 'mice' can be installed (31.3s)
# √ checking installed package size (502ms)
# √ checking package directory (667ms)
# √ checking for future file timestamps ...
# √ checking DESCRIPTION meta-information (681ms)
# √ checking top-level files ...
# √ checking for left-over files ...
# √ checking index information
# √ checking package subdirectories (605ms)
# √ checking R files for non-ASCII characters ...
# √ checking R files for syntax errors ...
# √ checking whether the package can be loaded (1.2s)
# √ checking whether the package can be loaded with stated dependencies (1.1s)
# √ checking whether the package can be unloaded cleanly (1.3s)
# √ checking whether the namespace can be loaded with stated dependencies (1.1s)
# √ checking whether the namespace can be unloaded cleanly (1.2s)
# √ checking loading without being on the library search path (1.2s)
# √ checking dependencies in R code (2.4s)
# √ checking S3 generic/method consistency (2.1s)
# √ checking replacement functions (1s)
# √ checking foreign function calls (1.5s)
# √ checking R code for possible problems (16.3s)
# √ checking Rd files (2.3s)
# √ checking Rd metadata ...
# √ checking Rd line widths (646ms)
# √ checking Rd cross-references (640ms)
# √ checking for missing documentation entries (1.5s)
# √ checking for code/documentation mismatches (5s)
# √ checking Rd \usage sections (3s)
# √ checking Rd contents (867ms)
# √ checking for unstated dependencies in examples (1.3s)
# √ checking contents of 'data' directory ...
# √ checking data for non-ASCII characters (443ms)
# √ checking data for ASCII and uncompressed saves (347ms)
# √ checking line endings in C/C++/Fortran sources/headers ...
# √ checking line endings in Makefiles
# √ checking compilation flags in Makevars (3.5s)
# √ checking for GNU extensions in Makefiles
# √ checking for portable use of $(BLAS_LIBS) and $(LAPACK_LIBS)
# √ checking use of PKG_*FLAGS in Makefiles ...
# √ checking use of SHLIB_OPENMP_*FLAGS in Makefiles ...
# √ checking pragmas in C/C++ headers and code ...
# √ checking compilation flags used ...
# N checking compiled code (26.1s)
# Note: information on .o files for x64 is not available
# File 'C:/Users/dinizma/AppData/Local/Temp/RtmpADNDSH/mice.Rcheck/mice/libs/x64/mice.dll':
# Found 'abort', possibly from 'abort' (C), 'runtime' (Fortran)
# Found 'exit', possibly from 'exit' (C), 'stop' (Fortran)
# Found 'printf', possibly from 'printf' (C)
#
# Compiled code should not call entry points which might terminate R nor
# write to stdout/stderr instead of to the console, nor use Fortran I/O
# nor system RNGs. The detected symbols are linked into the code but
# might come from libraries and not actually be called.
#
# See 'Writing portable packages' in the 'Writing R Extensions' manual.
# √ checking examples (44.7s)
# √ checking examples with --run-donttest (41.6s)
# √ checking for unstated dependencies in 'tests' (521ms)
# - checking tests ...
# √ Running 'testthat.R' [44s] (44.2s)
# √ checking for non-standard things in the check directory (44.3s)
# √ checking for detritus in the temp directory
#
# See
# 'C:/Users/dinizma/AppData/Local/Temp/RtmpADNDSH/mice.Rcheck/00check.log'
# for details.
#
#
# -- R CMD check results ---------------------- mice 3.13.7 ----
# Duration: 4m 11.6s
#
# > checking compiled code ... NOTE
# Note: information on .o files for x64 is not available
# File 'C:/Users/dinizma/AppData/Local/Temp/RtmpADNDSH/mice.Rcheck/mice/libs/x64/mice.dll':
# Found 'abort', possibly from 'abort' (C), 'runtime' (Fortran)
# Found 'exit', possibly from 'exit' (C), 'stop' (Fortran)
# Found 'printf', possibly from 'printf' (C)
#
# Compiled code should not call entry points which might terminate R nor
# write to stdout/stderr instead of to the console, nor use Fortran I/O
# nor system RNGs. The detected symbols are linked into the code but
# might come from libraries and not actually be called.
#
# See 'Writing portable packages' in the 'Writing R Extensions' manual.
#
# 0 errors √ | 0 warnings √ | 1 note x
Ok, thanks.
parameter
does not hurt any existing applications, so let's merge.
Closes #405