search

amices / mice

Multivariate Imputation by Chained Equations
https://amices.org/mice/
GNU General Public License v2.0
433 stars 107 forks source link

Including license in repository #470

Closed kequach closed 2 years ago

kequach commented 2 years ago

I checked for the license of this package and found it in the description file and on the website. However, it would be good to add a LICENSE file to make it clear which license is used. The benefit of adding such a file is that it shows up on the "about" section on the right side like this: image

I noticed that you use two licenses which has no clear schema. However, I found this link that showcases some ideas on how to add dual licenses to a repository: https://softwareengineering.stackexchange.com/questions/304874/declaring-multiple-licences-in-a-github-project If you would like I can create a pull request for this if you tell me what your preference would be.

stefvanbuuren commented 2 years ago

Not quite sure what you mean. The licence for the mice package is defined in DESCRIPTION. 

License: GPL-2 | GPL-3

Wouldn't that be enough?

kequach commented 2 years ago

Yes, it's enough. But it is a bit hidden from this repository. Adding the LICENSE file makes this information easier to find on Github. Not necessary, just a small improvement.

stefvanbuuren commented 2 years ago

OK, thanks.

I remember I had a GPL LICENCE text once, but the CRAN said to remove it (presumably because it is considered redundant). I guess I could include it and leave it out of the package build so that it shows in GitHub.

kequach commented 2 years ago

Ah interesting, I didn't know about that. I just know that other R packages include a (redundant) license, for example Tidyverse. It's also included in the package build which I assumed to be the standard.

stefvanbuuren commented 2 years ago

Now added. Thanks.