search

amices / mice

Multivariate Imputation by Chained Equations
https://amices.org/mice/
GNU General Public License v2.0
433 stars 107 forks source link

IPD Heckman imputation method #485

Closed johamunoz closed 1 year ago

johamunoz commented 2 years ago

New imputation method for individual patient data (IPD) and cluster data that follow a MNAR mechanism according to the Heckman selection model.

hanneoberman commented 2 years ago

@johamunoz Unfortunately, the checks failed... Could you please try to solve the CMD check WARNING?

johamunoz commented 2 years ago

Thanks a lot Hanna!! I will try

Have a lovely day!!

Johanna

On 5 May 2022, at 16:20, Hanne Oberman @.***> wrote:

@johamunoz https://github.com/johamunoz Unfortunately, the checks failed... Could you please try to solve the CMD check WARNING?

— Reply to this email directly, view it on GitHub https://github.com/amices/mice/pull/485#issuecomment-1118614537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB55T233PE4TDMRLPG4EZCDVIPKLXANCNFSM5VCGBQ3A. You are receiving this because you were mentioned.

hanneoberman commented 2 years ago

Hi Johanna, looks good! But would it be possible to add your function without so many dependencies? Currently, there are a hand full of packages added to the Imports part of the DESCRIPTION file. Preferably, these should be added under Suggests instead. The install.on.demand function then takes care of any missing dependencies whenever someone uses your imputation function.

stefvanbuuren commented 2 years ago

Hi Johanna, thanks for your contribution. Found some final glitches:

johamunoz commented 2 years ago

Thanks to you for allowing me to contribute in your package!! I have updated the code following your suggestions.

hanneoberman commented 2 years ago

@johamunoz Unfortunately, one of the checks failed again. Could you please try to solve the error? Let me know if you need some help!

johamunoz commented 2 years ago

Hi Hanna!! Thank you very much for checking this update!!. I'm not sure about the Ubuntu error but it looks like it could be a bug with the installation order. The only thing I found is that one of the suggested packages GJRM depends on another suggested package (mgcv). I have removed the last one from the suggested list of packages. Could you please check it again? Thank you very much for always helping me, Johanna

johamunoz commented 2 years ago

:(

johamunoz commented 2 years ago

Hi Hanna! Again sorry to bother you with this, but I am super lost and I dont know how to proceed.. :(

  1. Could you please approve the last change again? Also, I would like to ask you please :
  2. if you know how to extract the process list? To be exact, I know there is a problem in process 9626, probably it's the installation of a package but I don't know which one.
  3. From the list of packages to install I see only the packages with installation suggestion but not their dependencies. Do you know if this list should show both types of packages? Again thank you very much for your great help,

Kind regards, Johanna Johanna

stefvanbuuren commented 1 year ago

See #500